Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-chart-echarts): fix customize margin #18958

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix(plugin-chart-echarts): fix customize margin #18958

merged 1 commit into from
Mar 1, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem that chart will shrink when input customize X AXIS TITLE MARGIN or Y AXIS TITLE MARGIN.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-01-19.at.11.37.33.PM.mov

after

2022-02-28.11.53.31.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #18958 (2736663) into master (2bacedd) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18958   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        1641     1641           
  Lines       63511    63511           
  Branches     6421     6421           
=======================================
  Hits        42168    42168           
  Misses      19682    19682           
  Partials     1661     1661
Flag Coverage Δ
javascript 51.00% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.23% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bacedd...2736663. Read the comment docs.

villebro
villebro approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@rusackas rusackas merged commit c4e3c45 into apache:master Mar 1, 2022
@stephenLYZ stephenLYZ deleted the fix-title-margin branch March 1, 2022 07:22
villebro pushed a commit that referenced this pull request Apr 3, 2022
@stephenLYZ @villebro
fix(plugin-chart-echarts): fix customize margin (#18958)
1f4ff51 
(cherry picked from commit c4e3c45)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenLYZ @villebro @mistercrunch @rusackas